Hi Eugeniu,
My testing was limited to:
- make defconfig all
- make ARCH=arm CROSS_COMPILE=aarch64-linux-gnu- r8a7795_ulcb_defconfig all
- comparing .config before and after the re-sync
- running the newly imported Kconfig unit tests as seen below:
I tested whole patch-set with the other options: make config make defconfig make menuconfig make xconfig make gconfig make oldconfig
Reviewed-by: Masahiro Yamada yamada.masahiro@socionext.com Signed-off-by: Eugeniu Rosca erosca@de.adit-jv.com
Tested-by: Petr Vorel petr.vorel@gmail.com
$ make testconfig
============================= test session starts ============================= scripts/kconfig/tests/auto_submenu/__init__.py::test PASSED [ 7%] scripts/kconfig/tests/choice/__init__.py::test_oldask0 PASSED [ 14%] scripts/kconfig/tests/choice/__init__.py::test_oldask1 PASSED [ 21%] scripts/kconfig/tests/choice/__init__.py::test_allyes PASSED [ 28%] scripts/kconfig/tests/choice/__init__.py::test_allmod PASSED [ 35%] scripts/kconfig/tests/choice/__init__.py::test_allno PASSED [ 42%] scripts/kconfig/tests/choice/__init__.py::test_alldef PASSED [ 50%] scripts/kconfig/tests/choice_value_with_m_dep/__init__.py::test PASSED [ 57%] scripts/kconfig/tests/err_recursive_inc/__init__.py::test PASSED [ 64%] scripts/kconfig/tests/inter_choice/__init__.py::test PASSED [ 71%] scripts/kconfig/tests/new_choice_with_dep/__init__.py::test PASSED [ 78%] scripts/kconfig/tests/no_write_if_dep_unmet/__init__.py::test PASSED [ 85%] scripts/kconfig/tests/rand_nested_choice/__init__.py::test PASSED [ 92%] scripts/kconfig/tests/warn_recursive_dep/__init__.py::test PASSED [100%] ========================== 14 passed in 0.34 seconds ==========================
When applied all 6 patches, I got several errors (see bellow). I tested in on 2 distros (Debian unstable and openSUSE Tumbleweed). The code I applied is here, did I make error when applying patches? https://github.com/pevik/u-boot/tree/eugeniu/kconfig.v2
Kind regards, Petr
$ make testconfig python3 -B -m pytest ./scripts/kconfig/tests \ -o cache_dir=/home/pevik/install/src/u-boot.git/scripts/kconfig/tests/.cache \
============================= test session starts ============================== platform linux -- Python 3.6.5, pytest-3.3.2, py-1.5.3, pluggy-0.6.0 -- /usr/bin/python3 cachedir: scripts/kconfig/tests/.cache rootdir: /home/pevik/install/src/u-boot.git/scripts/kconfig/tests, inifile: pytest.ini collecting ... collected 14 items
scripts/kconfig/tests/auto_submenu/__init__.py::test FAILED [ 7%] scripts/kconfig/tests/choice/__init__.py::test_oldask0 FAILED [ 14%] scripts/kconfig/tests/choice/__init__.py::test_oldask1 FAILED [ 21%] scripts/kconfig/tests/choice/__init__.py::test_allyes PASSED [ 28%] scripts/kconfig/tests/choice/__init__.py::test_allmod PASSED [ 35%] scripts/kconfig/tests/choice/__init__.py::test_allno PASSED [ 42%] scripts/kconfig/tests/choice/__init__.py::test_alldef PASSED [ 50%] scripts/kconfig/tests/choice_value_with_m_dep/__init__.py::test PASSED [ 57%] scripts/kconfig/tests/err_recursive_inc/__init__.py::test PASSED [ 64%] scripts/kconfig/tests/inter_choice/__init__.py::test PASSED [ 71%] scripts/kconfig/tests/new_choice_with_dep/__init__.py::test FAILED [ 78%] scripts/kconfig/tests/no_write_if_dep_unmet/__init__.py::test PASSED [ 85%] scripts/kconfig/tests/rand_nested_choice/__init__.py::test PASSED [ 92%] scripts/kconfig/tests/warn_recursive_dep/__init__.py::test PASSED [100%]
=================================== FAILURES =================================== _____________________________________ test _____________________________________
conf = <conftest.Conf object at 0x7f7eeeaa6d30>
def test(conf): assert conf.oldaskconfig() == 0
assert conf.stdout_contains('expected_stdout')
E AssertionError
scripts/kconfig/tests/auto_submenu/__init__.py:12: AssertionError ----------------------------- Captured stdout call ----------------------------- [command] /home/pevik/install/src/u-boot.git/scripts/kconfig/conf --oldaskconfig Kconfig
[retcode] 0
[stdout] * * Linux Kernel Configuration * A (A) [Y/n/?] (NEW) A0 (A0) [Y/n/?] (NEW) A1_0 (A0_0) [N/y/?] (NEW) A1 (A1) [Y/n/?] (NEW) choice > 1. A1_0 (A1_0) (NEW) 2. A1_1 (A1_1) (NEW) choice[1-2?]: B (B) [N/y/?] (NEW) C (C) [N/y/?] (NEW) # # configuration written to .config #
[stderr]
[output for '.config'] # # Automatically generated file; DO NOT EDIT. # Linux Kernel Configuration # CONFIG_A=y CONFIG_A0=y # CONFIG_A0_0 is not set CONFIG_A1=y CONFIG_A1_0=y # CONFIG_A1_1 is not set # CONFIG_B is not set # CONFIG_C is not set
_________________________________ test_oldask0 _________________________________
conf = <conftest.Conf object at 0x7f7ef0e167b8>
def test_oldask0(conf): assert conf.oldaskconfig() == 0
assert conf.stdout_contains('oldask0_expected_stdout')
E AssertionError
scripts/kconfig/tests/choice/__init__.py:15: AssertionError ----------------------------- Captured stdout call ----------------------------- [command] /home/pevik/install/src/u-boot.git/scripts/kconfig/conf --oldaskconfig Kconfig
[retcode] 0
[stdout] * * Linux Kernel Configuration * Enable loadable module support (MODULES) [Y/n/?] (NEW) boolean choice 1. choice 0 (BOOL_CHOICE0) (NEW)
- choice 1 (BOOL_CHOICE1) (NEW)
choice[1-2?]: optional boolean choice [N/y/?] (NEW) tristate choice [M/y/?] (NEW) choice 0 (TRI_CHOICE0) [N/m/?] (NEW) choice 1 (TRI_CHOICE1) [N/m/?] (NEW) optional tristate choice [N/m/y/?] (NEW) # # configuration written to .config #
[stderr]
[output for '.config'] # # Automatically generated file; DO NOT EDIT. # Linux Kernel Configuration # CONFIG_MODULES=y # CONFIG_BOOL_CHOICE0 is not set CONFIG_BOOL_CHOICE1=y # CONFIG_TRI_CHOICE0 is not set # CONFIG_TRI_CHOICE1 is not set
_________________________________ test_oldask1 _________________________________
conf = <conftest.Conf object at 0x7f7ef0e167b8>
def test_oldask1(conf): assert conf.oldaskconfig('oldask1_config') == 0
assert conf.stdout_contains('oldask1_expected_stdout')
E AssertionError
scripts/kconfig/tests/choice/__init__.py:20: AssertionError ----------------------------- Captured stdout call ----------------------------- [command] /home/pevik/install/src/u-boot.git/scripts/kconfig/conf --oldaskconfig Kconfig
[retcode] 0
[stdout] * * Linux Kernel Configuration * Enable loadable module support (MODULES) [N/y/?] boolean choice 1. choice 0 (BOOL_CHOICE0) (NEW)
- choice 1 (BOOL_CHOICE1) (NEW)
choice[1-2?]: optional boolean choice [Y/n/?] (NEW) optional boolean choice
- choice 0 (OPT_BOOL_CHOICE0)
2. choice 1 (OPT_BOOL_CHOICE1) (NEW) choice[1-2?]: tristate choice 1. choice 0 (TRI_CHOICE0) (NEW)
- choice 1 (TRI_CHOICE1) (NEW)
choice[1-2?]: optional tristate choice [N/y/?] # # configuration written to .config #
[stderr]
[output for '.config'] # # Automatically generated file; DO NOT EDIT. # Linux Kernel Configuration # # CONFIG_MODULES is not set # CONFIG_BOOL_CHOICE0 is not set CONFIG_BOOL_CHOICE1=y CONFIG_OPT_BOOL_CHOICE0=y # CONFIG_OPT_BOOL_CHOICE1 is not set # CONFIG_TRI_CHOICE0 is not set CONFIG_TRI_CHOICE1=y
_____________________________________ test _____________________________________
conf = <conftest.Conf object at 0x7f7eee858400>
def test(conf): assert conf.oldconfig('config', 'y') == 0
assert conf.stdout_contains('expected_stdout')
E AssertionError
scripts/kconfig/tests/new_choice_with_dep/__init__.py:14: AssertionError ----------------------------- Captured stdout call ----------------------------- [command] /home/pevik/install/src/u-boot.git/scripts/kconfig/conf --oldconfig Kconfig
[retcode] 0
[stdout] * * Restart config... * * * Linux Kernel Configuration * A (A) [N/y/?] (NEW) y Choice ?
- Choice B (CHOICE_B)
2. Choice C (CHOICE_C) (NEW) choice[1-2?]: Choice2 ? 1. Choice D (CHOICE_D)
- Choice E (CHOICE_E)
3. Choice F (CHOICE_F) (NEW) choice[1-3?]: # # configuration written to .config #
[stderr]
[output for '.config'] # # Automatically generated file; DO NOT EDIT. # Linux Kernel Configuration # CONFIG_A=y CONFIG_CHOICE_B=y # CONFIG_CHOICE_C is not set # CONFIG_CHOICE_D is not set CONFIG_CHOICE_E=y # CONFIG_CHOICE_F is not set
===================== 4 failed, 10 passed in 0.21 seconds ====================== make[1]: *** [scripts/kconfig/Makefile:156: testconfig] Error 1 make: *** [Makefile:482: testconfig] Error 2