Hi Alex,
Open questions:
- what's the correct way of attributing the original authors? I've
added Co-authored-by, is that right? checkpatch doesn't seem to know any of the co- tags
I think that two authors (Alex and Jocelyn) have replied to your e-mail.
Maybe it would be doable to have S-o-B or Acked-by from them?
- currently there's no NAND support and I've no way of testing that,
so my inclination is towards leaving it like that until someone with that particular itch to scratch can look at it
As I've written in the other mail - please look into "mtdparts".
- you can select both USB and UDP fastboot, but the comments in the AOSP code suggest that needs fixing - again, I've no board I can
test USB fastboot on
I need to check if I do posses a bort with fastboot support (as I mostly test DFU).
- the USB and UDP code want consolidating, with this series there
would then be two separate implementations of the same protocol
Yes - this is an issue.
For USB the fastboot protocol (at least some its logic) is implemented in drivers/usb/gadget/f_fastboot.c
I think that some medium agnostic code (like protocol itself) can be unified.
I also think that it would be a good idea to have ./drivers/fastboot directory introduced to move common code there - and leave only USB related code in f_fastboot.c
Please as a reference, look on how ./drivers/dfu is organised.
- the syntax for the USB fastboot command changes from `fastboot
<controller>` to `fastboot usb <controller>`, that feels unacceptable and we probably want something like `fastboot <controller>` or `fastboot udp`?
Similar issue was with "thor"/"ums"/"dfu" command previously.
For backward compatibility we can make an alias:
fastboot <controller> -> fastboot usb <controller>
IMHO, it would be great to have
fastboot usb <controller> fastboot udp ip.... (etc)
(It would be great to have the same syntax as it is in Android).
- unrelated to this series, but a show-stopper for me, there's no FIT
image support, but that doesn't feel unsolveable - something like add an option to pass in the load address and/or use loadaddr, then something else to let you override the bootm invocation on the server side
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de