Re: [PATCH 4/9] net: add set_promisc function to enable/disable Promiscuous mode

On Thu, Jul 1, 2021 at 2:50 AM Tim Harvey tharvey@gateworks.com wrote:

Enabling promiscuous mode can be useful for DSA switches where each port has its own MAC address.

Signed-off-by: Tim Harvey tharvey@gateworks.com

include/net.h | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/include/net.h b/include/net.h index b95d6a6f60..cec8c98618 100644 --- a/include/net.h +++ b/include/net.h @@ -158,6 +158,7 @@ enum eth_recv_flags {

•             ROM on the board. This is how the driver should expose it
  

•             to the network stack. This function should fill in the
  

•             eth_pdata::enetaddr field - optional
  

• • set_promisc: Enable or Disable promiscuous mode
  */

struct eth_ops { int (*start)(struct udevice *dev); @@ -168,6 +169,7 @@ struct eth_ops { int (*mcast)(struct udevice *dev, const u8 *enetaddr, int join); int (*write_hwaddr)(struct udevice *dev); int (*read_rom_hwaddr)(struct udevice *dev);

•   int (*set_promisc)(struct udevice *dev, bool enable);
  

};

#define eth_get_ops(dev) ((struct eth_ops *)(dev)->driver->ops)

2.17.1

Reviewed-by: Ramon Fried rfried.dev@gmail.com