Hi Detlev, Hi Wolfgang,
On Tue, 29 Jun 2010 13:49:11 +0200 Detlev Zundel dzu@denx.de wrote:
Commit 460c2ce3 "MPC5200: workaround data corruption for unaligned local bus accesses" fixed the problem for MPC5200 only, but MPC512x is affected as well, so apply the same fix here, too.
Signed-off-by: Wolfgang Denk wd@denx.de Cc: Detlev Zundel dzu@denx.de Cc: Anatolij Gustschin agust@denx.de
arch/powerpc/cpu/mpc5xxx/Makefile | 5 ----- arch/powerpc/lib/Makefile | 16 ++++++++++++---- arch/powerpc/{cpu/mpc5xxx => lib}/memcpy_mpc5200.c | 0 3 files changed, 12 insertions(+), 9 deletions(-) rename arch/powerpc/{cpu/mpc5xxx => lib}/memcpy_mpc5200.c (100%)
Acked-by: Detlev Zundel dzu@denx.de
The only thing I wonder is the filename 'memcpy_mpc5200.c' as the code doesn't really have any 5200 specifics in it. What about 'memcpy_align32wrap' or something likew that to express the more general nature of the code?
'memcpy_align32wrap' isn't really good since the fixed memcpy also fixes 16-bit accesses, too.
BTW, shouldn't we fix print_buffer() also? do_mem_md() doesn't use memcpy() and the issue with corrupted dumps still remains here. I'm testing a patch to fix it. Will submit it soon.
Best regards, Anatolij