Hi Wolfgang,
On Fri, Mar 8, 2013 at 12:31 AM, Wolfgang Denk wd@denx.de wrote:
Dear Simon Glass,
In message 1362715633-20556-8-git-send-email-sjg@chromium.org you wrote:
We are introducing a new unified board setup and we want this to be the default. So we need to opt all architectures out first.
...
+- CONFIG_SYS_LEGACY_BOARD
This option should not be defined by board config files.This is an internal CONFIG defined by architectures which do notsupport CONFIG_SYS_GENERIC_BOARD. It is used as a check that boardsdon't accidentally define CONFIG_SYS_GENERIC_BOARD when theirarchitecture cannot support it, and U-Boot would then either notbuild or not work. When an architecture supports generic board,then CONFIG_SYS_LEGACY_BOARD can be removed from the architecture'sconfig.mk file so that generic board becomes available.Hm... I understand that you selected the ...LEGACY_BOARD name to make it easy to see the relation to ...GENERIC_BOARD? But then, the name is misleading - if my understanding is correct, then ...LEGACY_BOARD is NOT a _board_ specific config option, but an _architecture_ speci- fic one.
That's right.
Actually this is then not a real CONFIG_SYS_ thing at all.
Should we rather use something like __HAVE_ARCH_GENERIC_BOARD ?? This would also make clear this is an internal macro only.
Yes, I will do that. It switches the meaning to positive, but there is no sense in it being the 'default' right now anyway. Since it doesn't start with CONFIG_ I will have to define it in the Makefile, since it won't appear in autoconf.mk, but that is fine too, since only Makefiles will reference it.
Regards, Simon