On Thu, Feb 27, 2014 at 04:04:55AM +0000, Rommel G Custodio wrote:
Dear Pantelis Antoniou
Pantelis Antoniou <panto <at> antoniou-consulting.com> writes:
Remove the in-structure ops and put them in mmc_ops with a constant pointer to it.
This makes the mmc structure smaller as well as conserving code space (in theory).
First build is latest master. Second build was with your patch. Compare size output.
[local (powerpc-linux-gnuspe)]$ powerpc-linux-gnuspe-size obj- P5040DS_SPIFLASH_master/u-boot text data bss dec hex filename 463352 39236 314064 816652 c760c obj-P5040DS_SPIFLASH_master/u-boot
[local (powerpc-linux-gnuspe)]$ powerpc-linux-gnuspe-size obj- P5040DS_SPIFLASH/u-boot text data bss dec hex filename 463364 39256 314064 816684 c762c obj-P5040DS_SPIFLASH/u-boot
The size increase on ARM is smaller, but still there too.
So we aren't making the code smaller nor the binaries. Marek, was this your request to clean up or ? Will this help make device model stuff easier down the line?