Hi Masahiro,
On Thu, 17 Oct 2013 16:37:42 +0900, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Commit 27af930e changed the boards.cfg format and it changed boards_by_field() function incorrectly. For tegra cpus it returned Board Name field, not Target field.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Albert ARIBAUD albert.u.boot@aribaud.net
Commit 27af930e adjusted this part like follows:
-v field="$1" \ -v select="$2" \ -F "$FS" \ - '($1 !~ /^#/ && $field == select) { print $1 }' \ + '($1 !~ /^#/ && $field == select) { print $7 }' \ boards.cfg } boards_by_arch() { boards_by_field 2 "$@" ; } boards_by_cpu() { boards_by_field 3 "$@" "[: \t]+" ; } -boards_by_soc() { boards_by_field 6 "$@" ; } +boards_by_soc() { boards_by_field 4 "$@" ; }TAB is also treated as a field speparator, so we should have taken the 8th field for Tegra whereas the 7th field for the other cpus.
Fortunately, Board Name field and Target filed are the same for all Tegra LSIs. But we should not expect it.
Not sure I am following here, as the commit you mention does not change how tabs are processed.
Besides, the system should *not* be sensitive to tabs. If it is, this must be fixed and tabs removed.
Amicalement,