Hey Heinrich,
On 07.06.22 09:12, Heinrich Schuchardt wrote:
On 6/7/22 01:43, Alexander Graf wrote:
Now that we have a damage tracking API, let's populate damage done by UEFI payloads when they BLT data onto the screen.
Signed-off-by: Alexander Graf agraf@csgraf.de Reported-by: Da Xue da@libre.computer
lib/efi_loader/efi_gop.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c index 2c81859807..67286c9a60 100644 --- a/lib/efi_loader/efi_gop.c +++ b/lib/efi_loader/efi_gop.c @@ -33,6 +33,9 @@ struct efi_gop_obj { struct efi_gop ops; struct efi_gop_mode_info info; struct efi_gop_mode mode; +#ifdef CONFIG_DM_VIDEO
Please, heed the warnings provided by scripts/checkpatch.pl:
WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #174: FILE: lib/efi_loader/efi_gop.c:36: +#ifdef CONFIG_DM_VIDEO
I was mostly afraid of adding a dependency on struct udevice here. But since we already include video.h, I believe we're good. Happy to change it to only runtime checks.
Alex