On Tue, Nov 12, 2013 at 01:14:59PM +0100, Stefan Roese wrote:
From: Tapani Utriainen tapani@technexion.com
Add support for TechNexion TAO3530 SoM
This patch has been posted quite a long time ago. I ported it to the latest mainline U-Boot version. With some additional cleanup and enhancements.
Signed-off-by: Tapani Utriainen tapani@technexion.com CC: Sandeep Paulraj s-paulraj@ti.com Signed-off-by: Stefan Roese sr@denx.de Cc: Thorsten Eisbein thorsten.eisbein@head-acoustics.de Cc: Tom Rini trini@ti.com
Sorry for taking so long to get back to this, and I was going to just fixup a few things, until I got farther into the series:
diff --git a/arch/arm/include/asm/mach-types.h b/arch/arm/include/asm/mach-types.h index 440b041..cb7604a 100644 --- a/arch/arm/include/asm/mach-types.h +++ b/arch/arm/include/asm/mach-types.h @@ -470,6 +470,7 @@ extern unsigned int __machine_arch_type; #define MACH_TYPE_EUKREA_CPUIMX35SD 2821 #define MACH_TYPE_EUKREA_CPUIMX51SD 2822 #define MACH_TYPE_EUKREA_CPUIMX51 2823 +#define MACH_TYPE_OMAP3_TAO3530 2836 #define MACH_TYPE_SMDKC210 2838 #define MACH_TYPE_OMAP3_BRAILLO 2839 #define MACH_TYPE_SPYPLUG 2840
Put this into the config file until we re-sync mach-types.h, IF you need to suppot non-DT booting kernels.
diff --git a/board/technexion/tao3530/Makefile b/board/technexion/tao3530/Makefile new file mode 100644 index 0000000..2aff383 --- /dev/null +++ b/board/technexion/tao3530/Makefile
This needs to be re-written now.
printf("Error? GPIO 65 not available\n");
Here and elsewhere, printf without formatting chars should be puts.
- /* Set memory size environment variable, depending on revision */
- switch (tao3530_revision()) {
- case 0x2: /* Rev C1 -- 256MB */
setenv("mem_size", "mem=256M");break;- case 0x3: /* Rev A2/B2 -- 128MB */
setenv("mem_size", "mem=128M");break;- default:
printf("Warning: Unknown TAO3530 rev, setting mem=128M\n");- }
This hunk gets dropped in a later patch, just fixup/squash it in. The other patches that do similar things too.
+#define CONFIG_ARMV7 /* This is an ARM V7 CPU core */ +#define CONFIG_OMAP34XX /* which is a 34XX */ +#define CONFIG_OMAP3430 /* which is in a 3430 */ +#define CONFIG_OMAP3_TAO3530 /* working with TAO-3530 */
Unused.
+#undef CONFIG_USE_IRQ /* no support for IRQs */
... so don't #undef it please, it's never being set.
+#define CONFIG_SYS_BAUDRATE_TABLE {4800, 9600, 19200, 38400, 57600,\
115200}
Please use the default table then.
+#define CONFIG_SYS_PROMPT_HUSH_PS2 "> "
No need to set this.
+#define CONFIG_AUTO_COMPLETE +#define CONFIG_AUTOCOMPLETE
One of these is needed, not both.
+#define CONFIG_SYS_MEMTEST_START (OMAP34XX_SDRC_CS0) /* memtest */
/* works on */+#define CONFIG_SYS_MEMTEST_END (OMAP34XX_SDRC_CS0 + \
0x01F00000) /* 31MB */
Please see doc/README.memory-test
And please compare with omap3_beagle.h and similar, I think there's a few other style things that have changed since when this file was first done. Thanks!