10 Oct
2014
10 Oct
'14
4:41 a.m.
On 28 September 2014 09:15, Simon Glass sjg@chromium.org wrote:
On 28 September 2014 07:52, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
The function uclass_add() checks uc_drv->ops as follows:
if (uc_drv->ops) { dm_warn("No ops for uclass id %d\n", id); return -EINVAL; }It seems odd because it warns "No ops" when uc_drv->ops has non-NULL pointer. (Looks opposite.)
Anyway, most of UCLASS_DRIVER entries have no .ops member. This check makes no sense.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com
Acked-by: Simon Glass sjg@chromium.org
Applied to u-boot-dm/next, thanks!