Re: [U-Boot] [PATCH] fsl_diu: fix alignment error that caused malloc corruption

Dear "Nikita V. Youshchenko",

In message 200810030003.55574@blacky.localdomain you wrote:

commit 81489a85c4c3536ec54290ac9216b746ec346663 Author: Nikita V. Youshchenko yoush@debian.org Date: Thu Sep 25 00:44:00 2008 +0400

fsl_diu: fix alignment error that caused malloc corruption

When aligning malloc()ed screen_base, invalid offset was added.
This not only caused misaligned result (which did not cause hardware
misbehaviour), but - worse - caused screen_base + smem_len to
be out of malloc()ed space, which in turn caused breakage of
futher malloc()/free() operation.

This patch fixes screen_base alignment.

Also this patch makes memset() that cleans framebuffer to be executed
on first initialization of diu, not only on re-initialization. It looks
correct to clean the framebuffer instead of displaying random garbage;
I believe that was disabled only because that memset caused breakage
of malloc/free described above - which no longer happens with the fix
described above.

Signed-off-by: Nikita V. Youshchenko <yoush@debian.org>

The indentation of the commit message is wrong.

Please use git-format-patch to create patches.

Applied, thanks.

Best regards,

Wolfgang Denk