On 4/12/07, <b class="gmail_sendername">Grant Likely</b> &lt;<a href="mailto:grant.likely@secretlab.ca">grant.likely@secretlab.ca</a>&gt; wrote:<br><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>A few comments:<br><br>1. you need to add a Signed-of-by:&quot; line at the bottom of your comment block</blockquote><div><br>Oops. I started reading Documentation/SubmittingPatches. I just didn&#39;t get all the way through.
<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">2. Looks like whitespace has been mangled in this patch.&nbsp;&nbsp;Tabs are now<br>spaces and long lines have been wrapped.&nbsp;&nbsp;The patch doesn&#39;t apply.
<br>Your mail client probably did this to you.</blockquote><div><br>Which is why I&#39;ve changed to an attachment. <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
&gt; blocksize in ulong */<br>&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; buffer+=(cnt*ATAPI_READ_BLOCK_SIZE); /* ulong<br>&gt; blocksize in ulong */<br><br>3. Now that buffer is incremented by bytes, the comment no longer<br>applies.&nbsp;&nbsp;Remove it in your patch.
</blockquote><div><br>Fixed.......resubmitting <br></div><br></div>