On Fri, Jun 21, 2019 at 5:23 PM Bin Meng bmeng.cn@gmail.com wrote:
Hi Ramon,
On Fri, Jun 21, 2019 at 10:04 PM Ramon Fried rfried.dev@gmail.com wrote:
Add support for capturing ethernet packets and storing them in memory in PCAP(2.4) format, later to be analyzed by any PCAP viewer software (IE. Wireshark)
This feature greatly assist debugging network issues such as detecting dropped packets, packet corruption etc.
Signed-off-by: Ramon Fried rfried.dev@gmail.com Reviewed-by: Alex Marginean alexm.osslist@gmail.com Tested-by: Alex Marginean alexm.osslist@gmail.com
v2: Fix type assignmnet to header.ts_sec
Could you please add functionality as Alex suggested? Besides what Aleix mentioned, can you also add the sub-function in the pcap command to store the captured packets from memory to file system?
Sure, I started working on it, but it's a different patch Regarding command to store it on file system, I don't think it's a wise idea, There's plenty of options on how to store it, not only fatwrite, it could be sf write, mmc write, etc. I think it's better to document the feature and explain the different options users has to store the data. Basically it's just typing another command. Thanks, Ramon.
include/net.h | 29 ++++++++++++++++++ net/Kconfig | 22 ++++++++++++++ net/Makefile | 1 + net/net.c | 11 +++++++ net/pcap.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 146 insertions(+) create mode 100644 net/pcap.c
Regards, Bin