Dear FUJITA Kazutoshi,
In message 20100309.232841.106130457.fujita@soum.co.jp you wrote:
Subject: Re: [U-Boot] [Patch] ./drivers/pci/pci.c Date: Tue, 09 Mar 2010 14:27:25 +0100
Please provide a useful commit message, and add your Signed-off-by: line.
sorry, how about this?
regards,
That's actually still nort usable.
First, the Subject line would result in a commit message tile of "./drivers/pci/pci.c" - do you think this is a meaningful description of what this patch is doing?
Second, all the above text would become part of the commit message - this makes no sense either.
Please use git-format-patch to format the patches, add commets _below_ the "---" line, and use git-send-email to submit the patches.
this patch fixes to deal with PCI_BASE_ADDRESS_5 which was forgotten in pci_hose_config_device()
Signed-off-by: FUJITA Kazutoshi fujita@soum.co.jp
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index d6d2d6e..cd64a87 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -388,7 +388,7 @@ int pci_hose_config_device(struct pci_controller *hose,
I edited the commit message for you, and applied the patch now. Thanks.
Best regards,
Wolfgang Denk