26 Jan
2010
26 Jan
'10
10:09 a.m.
Wolfgang Denk wrote:
+/* Clear and set bits in one shot. These macros can be used to
clear and
- set multiple bits in a register using a single call. These macros can
- also be used to set a multiple-bit bit pattern using a mask, by
- specifying the mask in the 'clear' parameter and the new bit pattern
- in the 'set' parameter.
- */
Incorrect multi-line comment style.
Sorry, you have already found this point. I forgot to change it.
What exactly is the definition of a "register" here? Is this memory mapped I/O?
Yes, they are.
and - should we really invent our own, private way of doing this? Should we not rather reuse definitions already present in Linux?
How about using ioread*()/iowrite*() instead?
You are right. I will replace them.
Best regards, Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de
=====================================================================