
24 Jun
2012
24 Jun
'12
8:57 a.m.
Dear Otavio Salvador,
In message 1340482108-18468-4-git-send-email-otavio@ossystems.com.br you wrote:
In case an unidentified CPU type is detected it now returns i.MX<unidentified>, in a const char.
...
-static char *get_imx_type(u32 imxtype) +static const char *get_imx_type(u32 imxtype)
I agree with the const change.
return "unknown";
return "<unidentified>";
But in which way would "<unidentified>" be better than "unknown"? It just costs 7 more bytes of memory...
Please drop this change.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"Success covers a multitude of blunders." - George Bernard Shaw