Re: [PATCH 6/6] env: Add support for explicit write access list

On Thu, Jun 25, 2020 at 08:12:57PM +0200, Harald Seiler wrote:

Hi Marek,

On Wed, 2020-06-03 at 02:01 +0200, Marek Vasut wrote:

...

This option marks any U-Boot variable which does not have explicit 'w' writeable flag set as read-only. This way the environment can be locked down and only variables explicitly configured to be writeable can ever be changed by either 'env import', 'env set' or loading user environment from environment storage.

I haven't yet been able to get to the bottom of it but this patch seems to regress the `envtools` build for me. Here is the rather weird error message:

   HOSTCC  tools/env/fw_env_main.o
 In file included from tools/env/fw_env.c:15:
 include/env_flags.h:27:22: error: missing binary operator before token "("
  #if CONFIG_IS_ENABLED(ENV_WRITEABLE_LIST)
                       ^

Any idea what could be the cause for this?

We can't use CONFIG_IS_ENABLED()/etc in host-tool code, the macros aren't exposed.