On 1/17/25 12:25, Ibai Erkiaga wrote:
Ensure all Xilinx exclusive fpga commands have a KConfig symbol and dependency to FPGA_XILINX listed. Remove (Xilinx only) text from the help command.
Signed-off-by: Ibai Erkiaga ibai.erkiaga-elorza@amd.com
(no changes since v1)
cmd/Kconfig | 16 +++++++++++----- cmd/fpga.c | 9 +++++---- 2 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig index f3ba230db42..822adbc7da1 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1163,6 +1163,12 @@ config CMD_FPGA help FPGA support.
+config CMD_FPGA_LOADB
- bool "fpga loadb - load bitstream"
This should be default y for backward compatibility.
Commit message is not describing that you are introducing new symbol. And separate patch should be created for it also with adding something like
diff --git a/cmd/fpga.c b/cmd/fpga.c index 8c64e957db0f..9b0736427478 100644 --- a/cmd/fpga.c +++ b/cmd/fpga.c @@ -181,6 +181,7 @@ static int do_fpga_load(struct cmd_tbl *cmdtp, int flag, int argc, return fpga_load(dev, (void *)fpga_data, data_size, BIT_FULL, 0); }
+#if defined(CONFIG_CMD_FPGA_LOADB) static int do_fpga_loadb(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) { @@ -195,6 +196,7 @@ static int do_fpga_loadb(struct cmd_tbl *cmdtp, int flag, int argc,
return fpga_loadbitstream(dev, (void *)fpga_data, data_size, BIT_FULL); } +#endif
#if defined(CONFIG_CMD_FPGA_LOADP) static int do_fpga_loadp(struct cmd_tbl *cmdtp, int flag, int argc, @@ -357,7 +359,9 @@ static struct cmd_tbl fpga_commands[] = { U_BOOT_CMD_MKENT(info, 1, 1, do_fpga_info, "", ""), U_BOOT_CMD_MKENT(dump, 3, 1, do_fpga_dump, "", ""), U_BOOT_CMD_MKENT(load, 3, 1, do_fpga_load, "", ""), +#if defined(CONFIG_CMD_FPGA_LOADB) U_BOOT_CMD_MKENT(loadb, 3, 1, do_fpga_loadb, "", ""), +#endif #if defined(CONFIG_CMD_FPGA_LOADP) U_BOOT_CMD_MKENT(loadp, 3, 1, do_fpga_loadp, "", ""), #endif
The second issue was commented by Alexander.
Thanks, Michal