Re: [PATCH] arch/riscv/dts: Fix uart reg-shift on fu540/fu740 SiFive devices

January 23, 2023 8:08 PM, "Alexander von Gluck IV" kallisti5@unixzen.com wrote:

• Not specifying reg-shift creates a situation where the register

shift is unknown and can only be decoded via special compat cases.

• The device tree specification states:

"...reg-shift. If unspecified, the default value is 0." https://devicetree-specification.readthedocs.io/en/latest/chapter4-device-bi...

• Since the reg-shift for the SiFive boards is *NOT* 0, it shall

be defined as 2

Groan, ignore this patch.

I misread somewhere that the sifive,uart0 was 8250 compatible. It is not, and doesn't use any kind of shift other than registers fitting into struct of unions.

I'm herding too many cats.

-- Alex