Dear Simon Glass,
In message 1309376974-12943-1-git-send-email-sjg@chromium.org you wrote:
assert() is like BUG_ON() but compiles to nothing unless DEBUG is defined. This is useful when a condition is an error but a board reset is unlikely to fix it, so it is better to soldier on in hope. Assertion failures should be caught during development/test.
It turns out that assert() is defined separately in a few places in U-Boot with various meanings. This patch cleans up some of these.
Build errors exposed by this change (and defining DEBUG) are also fixed in this patch.
Signed-off-by: Simon Glass sjg@chromium.org
Changes in v2:
- Changed macros so that all code is compiled even if DEBUG is disabled
Changes in v3:
- Use panic() instead of printf()
- Use separate __assert_fail() function to reduce memory footprint
- Changed output format to match assert(3)
common/dlmalloc.c | 7 ------- include/common.h | 21 +++++++++++++++++++++ include/malloc.h | 8 -------- lib/qsort.c | 5 ----- lib/vsprintf.c | 8 ++++++++ 5 files changed, 29 insertions(+), 20 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk