Re: [U-Boot] [PATCH] crc32: Correct endianness of crc32 result

Dear Simon Glass,

In message 1365203470-9099-1-git-send-email-sjg@chromium.org you wrote:

When crc32 is handled by the hash library, it requires the data to be in big-endian format, since it reads it byte-wise. Thus at present the 'crc32' command reports incorrect data. For example, previously we might see:

+#ifdef USE_HOSTCC

• crc = htobe32(crc); memcpy(output, &crc, sizeof(crc));

+#else

• put_unaligned_be32(crc, output);

+#endif

Why is this depending on USE_HOSTCC, and not on the endianess?

And why do we need the #ifdef? Can we not always use htobe32() and put_unaligned_be32() ?

Best regards,

Wolfgang Denk