Wolfgang Denk wrote:
Dear "kevin.morfitt@fearnside-systems.co.uk",
In message 4B2548FF.6040103@fearnside-systems.co.uk you wrote:
Cleans up the s3c24x0 header files by changing the upper case members of the s3c24x0 register structures to lower case and changing all code that uses these register structures.
The commit message should also mention that you convert the code into using accessor functions.
You also perform a white space cleanup here. this may be a good thing (opinions differ), but in any case it is an unrelated change that must be performed in a separate commit.
All I really wanted to do was change the sc324x0 register struct members to lower case, but if I do that without cleaning up the white space I get checkpatch.pl errors, and if I don't change the code to use the accessor functions the patch will get NAK-ed anyway...and all I really want to do is get the code into a state where I can add support for the Embest SBC244-II Board!
I think I'll split the patches into a white-space change followed by an accessor function/s3c24x0 register change patch.
Note that the same applies to the other two patches.
Please also re-check the resulting code. I think there are some way too long lines, etc.
checkpatch.pl didn't report any line length errors before I emailed the patches. I'll check it again.
Best regards,
Wolfgang Denk