Hi Pekon,
On 13.03.2014 12:49, Gupta, Pekon wrote:
From: Stefan Roese [mailto:sr@denx.de]
Patch a7e36fc9 (mtd: nand: omap: remove unused #defines from common omap_gpmc.h) removed some MTD related defines. Including GPMC_NAND_ECC_LP_x8_LAYOUT. But this define is also needed for the memory controller configuration (only the x8 defines are needed, the x16 defines are the default). Without it the NAND subsystem is not configured correctly and booting into U-Boot does not work.
The root cause of this problem is in .. arch/arm/cpu/armv7/omap3/mem.c #if defined(GPMC_NAND_ECC_SP_x8_LAYOUT) || defined(GPMC_NAND_ECC_LP_x8_LAYOUT) where based on GPMC_NAND_ECC_LP_x8_LAYOUT, different controller configuration is selected.
I know as I introduced this code a while ago for this x8 NAND target. ;)
Unless you need a urgent fix,
Yes, I need an urgent fix. This board does not boot anymore. Note that Tom already pulled my patch into his TI repo. So this fix is on its way right now.
- I would suggest to use [1] instead. I'll try to get a cleaner version
of [1] incorporating other comments from Scott, soon.
- Alternatively, you can also look at [2], which is more robust but
was still under discussion.
Yes, your patches look more elegant. I suggest to move to them once the discussion has settled. And then remove these x8_LAYOUT defines completely when they are really not needed any more. But please not sooner.
Thanks, Stefan