24 Jan
2011
24 Jan
'11
7:53 p.m.
Dear Mike Rapoport,
In message 4D3D68A9.4040702@compulab.co.il you wrote:
Besides, since you're using I/O accessors anyway, the struct can replaces with base address and offset definitions.
We do not allow such construtcs in U-Boot. With C structs, you can have proper type checking by the compiler (well, at least assuming you have proper I/O accessors in place).
+#define NV_PA_APB_UARTC_BASE (NV_PA_APB_MISC_BASE + 0x6200) +#define NV_PA_APB_UARTD_BASE (NV_PA_APB_MISC_BASE + 0x6300) +#define NV_PA_APB_UARTE_BASE (NV_PA_APB_MISC_BASE + 0x6400) +#define NV_PA_PMC_BASE 0x7000E400
what is the purpose of NV_PA prefix here?
Good catch.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
When the bosses talk about improving productivity, they are never
talking about themselves.