Re: [U-Boot] [PATCH v2 06/21] pmic: Enable power_board_init() support at TRATS

Hi Stefano,

On 09/10/2012 12:30, Lukasz Majewski wrote:

...

...

This enforces my comment in previous patch. We have two CONFIG_ options, both must be turned on. So at least one is redundant.IMHO you can drop both of them if power_board_init() is declared weak.

I can define power_board_init() as __weak if you are OK with this :-).

IMHO yes, and call it board_power_init(). We know directly from the name that board_* function are often declared weak.

Ok, I will prepare v3 of this patch set.

...

In this case for sure CONFIG_POWER_INIT could be removed.

I agree that CONFIG_PMIC can be removed from this piece of code.

...

Best regards, Stefano Babic