
15 Apr
2022
15 Apr
'22
2:08 p.m.
On Mon, Apr 04, 2022 at 02:17:57PM -0400, Sean Anderson wrote:
A string like "test\n" would be broken up into the following sequence of prints by _serial_puts:
puts("test\n") putc('\r')
Although functionally this is the same as \r\n, it is not the standard sequence and caused tests to fail. Fix this by excluding the '\n' from the initial print. The above string will now be broken up like
puts("test") puts("\r\n")
Since we may now need to call ops->puts twice (with the associated retry logic), break that part of the function off into a helper.
Fixes: 7a76347189 ("serial: dm: Add support for puts") Signed-off-by: Sean Anderson sean.anderson@seco.com
Applied to u-boot/master, thanks!
--
Tom