Re: [PATCH 01/15] scsi: Tidy up comments for struct scsi_cmd

On 8/27/22 17:14, Simon Glass wrote:

These comments are bit of a mess. Tidy them up to match the correct coding style.

Signed-off-by: Simon Glass sjg@chromium.org

It would be preferable to use Sphinx style comments as you already did in include/asm-generic/global_data.h.

Best regards

Heinrich

---

include/scsi.h | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/include/scsi.h b/include/scsi.h index b47c7463c1d..e5d75b0cdca 100644 --- a/include/scsi.h +++ b/include/scsi.h @@ -16,26 +16,26 @@ struct udevice;

struct scsi_cmd {

• unsigned char cmd[16]; /* command */

• unsigned char cmd[16]; /* command */ /* for request sense */

• unsigned char sense_buf[64]

• unsigned char sense_buf[64] __attribute__((aligned(ARCH_DMA_MINALIGN)));

• unsigned char status; /* SCSI Status */
• unsigned char target; /* Target ID */
• unsigned char lun; /* Target LUN */
• unsigned char cmdlen; /* command len */
• unsigned long datalen; /* Total data length */
• unsigned char * pdata; /* pointer to data */
• unsigned char msgout[12]; /* Messge out buffer (NOT USED) */
• unsigned char msgin[12]; /* Message in buffer */
• unsigned char sensecmdlen; /* Sense command len */
• unsigned long sensedatalen; /* Sense data len */
• unsigned char sensecmd[6]; /* Sense command */
• unsigned long contr_stat; /* Controller Status */
• unsigned long trans_bytes; /* tranfered bytes */

• unsigned char status; /* SCSI Status */
• unsigned char target; /* Target ID */
• unsigned char lun; /* Target LUN */
• unsigned char cmdlen; /* command len */
• unsigned long datalen; /* Total data length */
• unsigned char *pdata; /* pointer to data */
• unsigned char msgout[12]; /* Messge out buffer (NOT USED) */
• unsigned char msgin[12]; /* Message in buffer */
• unsigned char sensecmdlen; /* Sense command len */
• unsigned long sensedatalen; /* Sense data len */
• unsigned char sensecmd[6]; /* Sense command */
• unsigned long contr_stat; /* Controller Status */
• unsigned long trans_bytes; /* tranfered bytes */

• unsigned int priv;
• enum dma_data_direction dma_dir;

• unsigned int priv;

• enum dma_data_direction dma_dir; };

  /*-----------------------------------------------------------