6 Apr
2021
6 Apr
'21
1:46 a.m.
On Mon, Apr 5, 2021 at 2:27 PM Peter Robinson pbrobinson@gmail.com wrote:
On Mon, Mar 1, 2021 at 10:34 PM Tim Harvey tharvey@gateworks.com wrote:
The fsl-usb dt bindings in Linux default dr_mode to 'host' for backward compatibility however U-Boot prints an error if this property does not exist. Declare it in the Gateworks Ventana device-trees to avoid the error.
Is there any reason not to fix the driver not to error if this property is missing rather than working around it like this?
Peter,
The usb_get_dr_mode function that produces the error is used by a number of drivers that are not all going to have the same default. I think it's best to augment the device-tree anyway (which I will likely do in Linux as well).
Tim