Re: [PATCH 07/18] Convert CONFIG_USB_XHCI_EXYNOS et al to Kconfig

On Thu, Jun 09, 2022 at 10:12:20AM +0900, Minkyu Kang wrote:

Hi,

2022년 6월 8일 (수) 21:26, Tom Rini trini@konsulko.com님이 작성:

...

This converts the following to Kconfig: CONFIG_USB_XHCI_EXYNOS CONFIG_USB_EHCI_EXYNOS

Signed-off-by: Tom Rini trini@konsulko.com

drivers/usb/host/Kconfig | 16 ++++++++++++++++ include/configs/exynos5250-common.h | 5 ----- include/configs/exynos5420-common.h | 2 -- include/configs/odroid.h | 3 --- include/configs/odroid_xu3.h | 3 --- include/configs/smdk5420.h | 1 - 6 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 5d0855ffcc79..413bec0f4a1a 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -32,6 +32,14 @@ config USB_XHCI_DWC3_OF_SIMPLE Support USB2/3 functionality in simple SoC integrations with USB controller based on the DesignWare USB3 IP Core.

+config USB_XHCI_EXYNOS

•   bool "Support for Samsung Exynos5 family on-chip xHCI USB
  

controller"

•   depends on ARCH_EXYNOS5
  

•   default y
  

•   help
  

•     Enables support for he on-chip xHCI controller on Samsung Exynos5
  

•     SoCs.
  

config USB_XHCI_MTK bool "Support for MediaTek on-chip xHCI USB controller" depends on ARCH_MEDIATEK @@ -157,6 +165,14 @@ config USB_EHCI_ATMEL ---help--- Enables support for the on-chip EHCI controller on Atmel chips.

+config USB_EHCI_EXYNOS

•   bool "Support for Samsung Exynos EHCI USB controller"
  

•   depends on ARCH_EXYNOS
  

•   default y
  

•   ---help---
  

•     Enables support for the on-chip EHCI controller on Samsung Exynos
  

•     SoCs.
  

config USB_EHCI_MARVELL bool "Support for Marvell on-chip EHCI USB controller" depends on ARCH_MVEBU || ARCH_KIRKWOOD || ARCH_ORION5X diff --git a/include/configs/exynos5250-common.h b/include/configs/exynos5250-common.h index 82cb8aff7b52..8d91a7de5cde 100644 --- a/include/configs/exynos5250-common.h +++ b/include/configs/exynos5250-common.h @@ -13,11 +13,6 @@

#define CONFIG_SYS_SDRAM_BASE 0x40000000

-/* USB */ -#define CONFIG_USB_EHCI_EXYNOS

-#define CONFIG_USB_XHCI_EXYNOS

/* DRAM Memory Banks */ #define SDRAM_BANK_SIZE (256UL << 20UL) /* 256 MB */

diff --git a/include/configs/exynos5420-common.h b/include/configs/exynos5420-common.h index 5e1aba7692e0..35bf3c2fb4a7 100644 --- a/include/configs/exynos5420-common.h +++ b/include/configs/exynos5420-common.h @@ -27,6 +27,4 @@ #define CONFIG_LOWPOWER_FLAG 0x02020028 #define CONFIG_LOWPOWER_ADDR 0x0202002C

-#define CONFIG_USB_XHCI_EXYNOS

#endif /* __CONFIG_EXYNOS5420_H */ diff --git a/include/configs/odroid.h b/include/configs/odroid.h index dec658dd13a3..11a4a409dbaf 100644 --- a/include/configs/odroid.h +++ b/include/configs/odroid.h @@ -149,9 +149,6 @@ /* Security subsystem - enable hw_rand() */ #define CONFIG_EXYNOS_ACE_SHA

-/* USB */ -#define CONFIG_USB_EHCI_EXYNOS

/*

• Supported Odroid boards: X3, U3
• TODO: Add Odroid X support

diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h index 8d24a03b722d..476bde53572d 100644 --- a/include/configs/odroid_xu3.h +++ b/include/configs/odroid_xu3.h @@ -16,9 +16,6 @@

#define SDRAM_BANK_SIZE (256UL << 20UL) /* 256 MB */

-/* USB */ -#define CONFIG_USB_EHCI_EXYNOS

/* DFU */ #define DFU_DEFAULT_POLL_TIMEOUT 300 #define DFU_MANIFEST_POLL_TIMEOUT 25000 diff --git a/include/configs/smdk5420.h b/include/configs/smdk5420.h index f8d2fafd2788..48f6e27006f0 100644 --- a/include/configs/smdk5420.h +++ b/include/configs/smdk5420.h @@ -20,7 +20,6 @@ #define CONFIG_SYS_SDRAM_BASE 0x20000000

/* USB */

Why don't you delete this line too?

Missed that one, thanks.