Re: [U-Boot] [PATCH v3 3/5] TFTP: net/tftp.c: add server mode receive

Hi Luca,

Signed-off-by: Luca Ceresoli luca.ceresoli@comelit.it Cc: Wolfgang Denk wd@denx.de

Acked-by: Detlev Zundel dzu@denx.de

Just for the future:

[...]

diff --git a/net/tftp.h b/net/tftp.h index e3dfb26..3abdf7b 100644 --- a/net/tftp.h +++ b/net/tftp.h @@ -2,6 +2,8 @@

• LiMon - BOOTP/TFTP.
• Copyright 1994, 1995, 2000 Neil Russell.

• • Copyright 2011 Comelit Group SpA

• •               Luca Ceresoli <luca.ceresoli@comelit.it>
    

  • (See License)
  */

@@ -16,6 +18,10 @@ /* tftp.c */ extern void TftpStart (void); /* Begin TFTP get */

+#ifdef CONFIG_CMD_TFTPSRV +extern void TftpStartServer(void); /* Wait for incoming TFTP put */ +#endif

/**********************************************************************/

#endif /* __TFTP_H__ */

I think we don't need the ifdefs in header files, or am I missing something? I _really_ like to avoid ifdefs wherever we can ;)

Cheers Detlev