+Heinrich Schuchardt
Hi Heinrich,
On Wed, 20 Jan 2021 at 20:11, Simon Glass sjg@chromium.org wrote:
At present when logging is not enabled, all log() calls become nops. This does not seem right, since if the log level is high enough then there should be some sort of message. So in that case, this series updates it to print the message if the log level is above LOGL_INFO.
This mimics the behaviour for the log_...() macros like log_debug() and log_info(), so we can drop the special case for these.
Also the current implementation does not support multiple log calls on the same line nicely. The tags are repeated so the line is very hard to read. This series adds that as a new feature.
Changes in v2:
- Move the newline check into log_dispatch()
- Update commit message and cover letter to mention log_...() macros
- Add a test for !CONFIG_LOG
- Update log() to (effectively) call debug() for log_level == LOGL_DEBUG
Simon Glass (6): log: Set up a flag byte for log records log: Handle line continuation log: Add return-checking macros for 0 being success sandbox: log: Avoid build error with !CONFIG_LOG tpm: Don't select LOG log: Convert log values to printf() if not enabled
I should have sent this series to you as well, since you had a comment on the original version.
It is at u-boot-dm/log-working if that is easier.
Regards, Simon