On 09/27/2011 02:28 AM, Scott Wood wrote:
On 09/26/2011 03:27 AM, Simon Schwarz wrote:
On 09/23/2011 07:22 PM, Scott Wood wrote:
On 09/23/2011 11:36 AM, Simon Schwarz wrote:
Added a nand_base.h header that defines all prototypes of nand_base.c functions.
Just add the new prototypes to include/linux/mtd/nand.h (which gets included by nand.h), that's the header that goes with drivers/mtd/nand/nand_base.c.
That was my first intention. I changed my mind because of the name collisions.
This is necessary because these functions were often copied in SPLs.
You'd rather add new #includes to dozens of files, and keep duplicated code around, than fix a few SPLs? NACK.
Where do you see duplicated code? The additional include?
Sorry, I misparsed what was meant by the "this" in "this is necessary because these functions were often copied...".
so in essence I will:
- rename the inline functions
- just add the functions used in SPL now
- make better patch-splitting
objections?
Sounds good.
-Scott
Ok, new patch RFC is out. I didn't rename the inline functions because none of the duplicated names are used in an SPL.
Comments?
Regards Simon