On 2024-04-01 12:08, Sumit Garg wrote:
On Mon, 1 Apr 2024 at 15:15, Jonas Karlman jonas@kwiboo.se wrote:
Hi Sumit,
On 2024-04-01 10:52, Sumit Garg wrote:
Hi Jonas,
On Mon, 1 Apr 2024 at 01:59, Jonas Karlman jonas@kwiboo.se wrote:
This series adds support for new clocks used in linux v6.8 device trees, enables use of FIT signature check for checksum validation and fixes loading FIT from SD-card when loading FIT from eMMC fails.
After this series it should be possible to move RK3399 boards to use OF_UPSTREAM in a future patch once dts/upstream move to a v6.8+ tag.
Thanks for putting this effort together. A switch to v6.8 tag for OF_UPSTREAM will happen as part of patch [1]. So if you want to save further effort then you can just rebase with a switch to OF_UPSTREAM once that patch [1] lands in next.
Because this is a jump of device tree files from v5.14-rc1 to v6.8, reviewability and being able to cherry-pick these changes to my rk3xxx-2024.04 branch, I think it is much more appropriate to first sync everything to v6.8 and then in a separate series move to OF_UPSTREAM. Else it can be very hard to understand some of the changes that has been and was needed to be made to u-boot.dtsi files.
That's fair given it's a long pending DT sync.
Reviewability is one of the shortcomings with a switch to OF_UPSTREAM.
I suppose the reasoning behind this thinking can be that people are used to reviewing DTs alongside driver changes. However, these patches aren't actual DT changes but rather DT imports which IMHO is a distraction for the reviewer. The actual DT can be looked into dts/upstream/ directory while reviewing the changes.
Things like following was easier to spot when reviewing DT syncs: - A property that U-Boot depends on gets removed, as in [1]. - Some DT changes can break changes that has been made to u-boot.dtsi files, e.g. a symbol to a node is no longer available in upstream but referenced in u-boot.dtsi files (happened in this series). - Changes in DT may require a workaround in a u-boot.dtsi file. - u-boot.dtsi contains workarounds that has not yet been upstream but can be removed in a future DT sync. - Driver incompatibilities due to initial driver imported from vendor ended up not fully compatible with upstream linux driver / dt-binding.
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id...
Regards, Jonas
-Sumit
Regards, Jonas
[1] https://lists.denx.de/pipermail/u-boot/2024-March/549611.html
-Sumit
I have runtime tested this series on following devices:
- 96boards Rock960
- Khadas Edge Captain
- Pine64 PineBook Pro
- Pine64 RockPro64
- Radxa ROCK 4C+
- Radxa ROCK 4SE
- Radxa ROCK Pi 4A
- Radxa ROCK Pi 4B+
This series depends on the following series:
- Enable booting from SPI flash on ROCK Pi 4 [1]
- rockchip: spl: Cache boot source id for later use [2]
A copy of this series and all its depends can be found at [3]
[1] https://patchwork.ozlabs.org/cover/1912469/ [2] https://patchwork.ozlabs.org/cover/1915071/ [3] https://github.com/Kwiboo/u-boot-rockchip/commits/rk3399-dt-sync-v1