-----Original Message----- From: Linus Walleij linus.walleij@linaro.org Sent: Monday, September 16, 2024 2:23 AM To: William Zhang william.zhang@broadcom.com Cc: u-boot@lists.denx.de; Dario Binacchi dario.binacchi@amarulasolutions.com; Michael Trimarchi michael@amarulasolutions.com; Anand Gore anand.gore@broadcom.com; Kursad Oney kursad.oney@broadcom.com; Philippe Reynes philippe.reynes@softathome.com; Florian Fainelli florian.fainelli@broadcom.com; Miquel Raynal miquel.raynal@bootlin.com; Kamal Dasu kamal.dasu@broadcom.com; David Regan dregan@broadcom.com Subject: Re: [PATCH 0/7] mtd: nand: brcmnand: Backported fixes from Linux
On Mon, Sep 16, 2024 at 6:45 AM William Zhang william.zhang@broadcom.com wrote:
Yes we have it working. And your patches works too after fixing two Issues that I will comment on the specific patch.
Yay!
You will need to enable the NAND related configurations and the nand dts node.
Aha maybe I simply missed the DTS node...
You can use existing dts node to set the specific ecc level, oob size and ecc step size. Or use the new automatically detection from the strap property brcm,nand-ecc-use-strap that I upstreamed to linux.
I was planning to used the strap, which is ... what we should have been doing all the time. Oh well, no turning back time I guess. Maybe we can fix a lot of DTS:es to use the strap though?
Yes we will upstream the dts including the binding document and other related patches. Your series can go in first.
What SoC do you use?
This is on BCM6846.
6846 will work. Let me know if it still does not work after dts fix.
Thanks William! Linus