On Thursday 05 April 2012 09:15:12 Bishop, Mark wrote:
From: Mike Frysinger
If we attempt to probe beyond the end of flash, MEMGETBADBLOCK will fail
(as well it should), but we end up erroring out with the distracting: Cannot read bad block mark: Invalid argument
Instead of the correct error: Too few good blocks within range
Re-order the tests so we check for the end of the flash before probing so we don't probe blocks that don't exist.
Applied the patch:
root:/bin> fw_printenv Too few good blocks within range
good -- that's what should be displayed. i had to hack up my local printenv for testing against /dev/zero and had to guess at the results :).
ioctl(3, MEMGETBADBLOCK, [393216]) = 1
this is what we need to root cause. but let's do it in the existing thread. -mike