Hi Weijie,
thanks for reviewing. Could you please also review the latest RFC version of my "generification" of the legacy lzma support as well? I really would like to see some review comments before sending v7 of this patchset to get it (hopefully) accepted in this merge window.
http://patchwork.ozlabs.org/project/uboot/patch/20200410110431.12256-1-sr@de... http://patchwork.ozlabs.org/project/uboot/patch/20200410110431.12256-2-sr@de... http://patchwork.ozlabs.org/project/uboot/patch/20200410110431.12256-2-sr@de...
Thanks, Stefan
On 15.04.20 09:19, Weijie Gao wrote:
On Fri, 2020-03-06 at 15:14 +0100, Stefan Roese wrote:
This function returns "-1" (true) upon error. So the function name does not match its implementation which is confusing. This patch renames the function to dqs_test_error() which makes the code easier to read.
Also change the return type to bool and return "true" or "false".
Signed-off-by: Stefan Roese sr@denx.de Cc: Weijie Gao weijie.gao@mediatek.com Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com
arch/mips/mach-mtmips/ddr_cal.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Weijie Gao weijie.gao@mediatek.com
Viele Grüße, Stefan