Re: [U-Boot] [PATCH] Improve DaVinci SPI speed

Dear Delio Brignoli,

In message 15866EAE-624B-4850-B10F-78AB99E3A1A2@audioscience.com you wrote:

On 21/05/2010, at 15:13, Wolfgang Denk wrote:

...

...

• 		*rxp = buf_reg_val & 0xFF;	
  

• 		rxp++;
  

• 	}
  

Please change into:

	if (rxp)
		*rxp++ = buf_reg_val & 0xFF;

Are you sure? Is folding that 3 line block into a one liner really worth the loss of readability? I know what that means, so do you and many others on this ML, but that's bound to raise a few eyebrows. A quick

Removing the need for braces is a good thing.

This is plain C, without any tricks or loopholes.

in a case like this. In the end it's your decision: if you like to be kinky, it's your prerogative ;-)

Kinky? Funny how you see that.

Best regards,

Wolfgang Denk