On Tuesday, December 08, 2015 at 01:34:53 PM, Chin Liang See wrote:
On Mon, 2015-12-07 at 18:46 +0100, Marek Vasut wrote:
On Monday, December 07, 2015 at 03:56:01 PM, Chin Liang See wrote: [...]
The cpu_eth_init() could use improvement, but we don't support generic reset handling yet I believe. That's the only thing which is obviously visible there, which could be improved.
The other thing which might use improvement is the FPGA registration, I suspect that might recycle the bindings from current linux 4.4.x at some point and move to DT as well.
Nice, looking forward then :)
To further clean-up, I am thinking we can move do_bridge to reset_manager.c too. I can do this if it sound good to you.
It's not reset-manager specific though, is it ?
All bridges are still release through reset manager except the fpga2sdram. Since we bridge assert at reset manager, consolidating these deassert function will make misc.c cleaner.
OK, it might be better if we discuss this over a patch, so let's see how that looks.
Best regards, Marek Vasut