Re: [PATCH 2/3] dts: sama5d2: add TCB node

On 2/2/22 11:46 AM, Clément Léger wrote:

Hello Clement,

Thank you for the patch.

Add the device-tree node to describe the TCB timer.

Signed-off-by: Clément Léger clement.leger@bootlin.com

arch/arm/dts/sama5d2.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)

diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi index 038cd73c03..c03a9d423c 100644 --- a/arch/arm/dts/sama5d2.dtsi +++ b/arch/arm/dts/sama5d2.dtsi @@ -700,6 +700,12 @@ clocks = <&h32ck>; };

•                   tcb0: timer@f800c000 {
  

•                           compatible = "atmel,sama5d2-tcb";
  

•                           reg = <0xf800c000 0x100>;
  

•                           clocks = <&tcb0_gclk>;
  

This node needs to have exactly 3 clocks, according to this documentation here in Linux:

Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml

Also the list of required properties contain multiple entries compared to your node.

We need to have this node exactly as the one in Linux DT.

Eugen

•                   };
  

•                    watchdog@f8048040 {
                             compatible = "atmel,sama5d4-wdt";
                             reg = <0xf8048040 0x10>;
  

-- 2.34.1