-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Prafulla Wadaskar Sent: Tuesday, May 05, 2009 11:41 AM To: Wolfgang Denk; Jean-Christophe PLAGNIOL-VILLARD Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit Subject: Re: [U-Boot] [PATCH v6] Marvell Kirkwood family SOC support
-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Tuesday, May 05, 2009 4:21 AM To: Jean-Christophe PLAGNIOL-VILLARD Cc: Prafulla Wadaskar; u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit Subject: Re: [U-Boot] [PATCH v6] Marvell Kirkwood family SOC support
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message 20090504223746.GE13923@game.jcrosoft.org you wrote:
please move to include/asm-arm/u-boot-arm.h
This change request makes no sense to me. Please leave as is.
all other arm specific init are already store there so
for me it's
make sense to have them all store at the same place
arch_misc_init() is not exactly ARM specific. It might as
well be used
by other architectures (ievenif this is currently not the case).
I agree with Wolfgang on this. arch_misc_init() can be used by any architecture. It may not be currently used by other architectures. Same applies for arch_cpu_init() too
Hi Jean, For my next patch I am not changing for arch_misc_init(), i.e. keeping it in common.h There are other architectures (non ARM too) using cpu_init() declared in their respective headers. It make more sense to move them to common.h along with newly defined arch_cpu_init(). Shall I do this as a part of this patch? Or separate patch?
Regards.. Prafulla . .
Regards.. Prafulla . .
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot