Hi Simon,
On Wed, Jan 08, 2020 at 10:39:34AM -0700, Simon Glass wrote:
On Tue, 24 Dec 2019 at 09:52, Eugeniu Rosca roscaeugeniu@gmail.com wrote:
[5] New usage adtimg addr <addr> - Set image location to <addr> adtimg dump - Print out image contents adtimg get dt --index=<i> [avar [svar]] - Get DT address and size by index
[6] Soon-to-be-provided "by id|rev" add-on functionality adtimg get dt --id=<id> --rev=<rev> [avar [svar [ivar]]]
- Get DT address/size/index by id|rev fields
Cc: Sam Protsenko semen.protsenko@linaro.org Signed-off-by: Eugeniu Rosca erosca@de.adit-jv.com
cmd/adtimg.c | 217 +++++++++++++++++++++++++++++++++++++-------------- 1 file changed, 158 insertions(+), 59 deletions(-)
Can you please add a test for this command?
Many thanks for the inputs. Two questions:
- The binary which adtimg operates on is generated by means of a host tooling [1] which is actively developed and hence continuously incorporates new features. Only the recent versions of [1] (obsoleting Debian packages like [2]) may be used to generate a valid test image for the adtimg U-Boot command. I think Sam found an elegant solution in [3] to make the hex dump of the test image part of the test itself, as opposed to below: - require the users to install the correct tool version on the host, - embed the required tool version into U-Boot and track its version, I plan to go the same route and just want to make sure we all agree on the approach just described.
- Since this series is already reviewed, are you fine if the test is submitted in a follow-up series, accompanied by a number of new adtimg features sitting in my queue?
[1] https://android.googlesource.com/platform/system/tools/mkbootimg/ [2] https://packages.debian.org/sid/android-tools-mkbootimg [3] https://patchwork.ozlabs.org/patch/1215287/