Hi, Stefano,
2010/12/27 Stefano Babic sbabic@denx.de:
On 12/22/2010 02:23 PM, Jason Liu wrote:
Add initial support for MX53EVK board support. FEC, SD/MMC, UART, I2C, have been support.
Signed-off-by: Jason Liu r64343@freescale.com
Changes for v2: -Address the comments from Stefano, Albert and Wolfgang, -remove the ivt.S file and use imximage.cfg instead, -remove the ivt link to u-boot -Address the comments from Stefano, -Correct the copyright issue, -Use mxc_get_gpio() and mxc_set_gpio() accessors. -Get rid of system_rev, -use i2c enumeration value (0,1,..N) instead of BASE address, -use fsl_pmic i2c interface, -Add comments for why manage the pmic in a different way for TO2 -Remove the comments from configs/mx53evk.h, - /* - * Disabled for now due to build problems under Debian and a significant - * increase in the final file size: 144260 vs. 109536 Bytes. - */ -Address the comments from Wolfgang, -Move CONFIG_SYS_TEXT_BASE to board config file, -Remove the comments from configs/mx53evk.h - /* size in bytes reserved for initial data */ #define BOARD_LATE_INIT -Change the comments, * Hardware drivers to * UART drivers
MAINTAINERS | 3 + board/freescale/mx53evk/Makefile | 48 +++++ board/freescale/mx53evk/mx53evk.c | 393 +++++++++++++++++++++++++++++++++++++ boards.cfg | 1 + include/configs/mx53evk.h | 216 ++++++++++++++++++++ 5 files changed, 661 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS index 0590ad9..c87ca56 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1085,6 +1085,9 @@ Peter Meerwald devel@bct-electronic.com
bct-brettl2 BF536
+Jason Liu r64343@freescale.com
- MX53evk i.MX53
Why do you add your name at the end of the Blackfin list and not inside the ARM list ? Please maintain the list sorted.
OK, I will put it into the ARM list.
+void power_init(void) +{
- unsigned int val;
- /* Set VDDA to 1.25V */
- val = pmic_reg_read(REG_SW_2);
- val = (val & (~0x1F)) | 0x1A;
I have already commented this. Please drop all fix constants and use already provided #define or add new ones if needed.
Do you think that both 0x1F and 0x1A should be used with #define?
- if (is_soc_rev(CHIP_REV_2_0) == 0) {
- /* Set VCC to 1.3V for TO2 */
- val = pmic_reg_read(REG_SW_1);
- val = (val & (~0x1F)) | 0x1C;
Ditto.
Do you think that both 0x1F and 0x1C should be used with #define?
+int board_init(void) +{
- gd->bd->bi_arch_number = MACH_TYPE_MX53_EVK;
- /* address of boot parameters */
- gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
- setup_iomux_uart();
You sent a patch for mx51evk moving this call in board_early_init_f. Do we need the same for mx53evk ?
Yes, we need the same for mx53evk.
+#ifdef BOARD_LATE_INIT +int board_late_init(void) +{ +#ifdef CONFIG_I2C_MXC
Is there a possibility to have a working board if CONFIG_I2C_MXC and BOARD_LATE_INIT are not set ? If not, it should be better to check if they are set on the beginning of this file and reporting a compile error if they are not set, and removing the #ifdef in this function.
OK, I will remove it.
Thanks for the review.
Best regards, Stefano Babic
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot