Hi Wolfgang,
Wolfgang Denk wrote:
Note that there are compiler warnings generated from your code:
ks8695eth.c: In function `eth_send': ks8695eth.c:217: warning: passing arg 2 of `memcpy' discards qualifiers from pointer target type ks8695eth.c:220: warning: passing arg 1 of `memset' makes pointer from integer without a cast
Please submit a (new, incremental) patch for this one!
Ok, attached.
Thanks Greg
------------------------------------------------------------------------ Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com SnapGear -- a CyberGuard Company PHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
diff -Naur --exclude=CVS u-boot.cvs/drivers/ks8695eth.c u-boot/drivers/ks8695eth.c --- u-boot.cvs/drivers/ks8695eth.c 2005-05-20 08:39:43.000000000 +1000 +++ u-boot/drivers/ks8695eth.c 2005-05-21 00:03:02.000000000 +1000 @@ -214,10 +214,10 @@ packet, len);
dp = &ks8695_tx[next]; - memcpy((void *) dp->addr, packet, len); + memcpy((void *) dp->addr, (void *) packet, len);
if (len < 64) { - memset(dp->addr+len, 0, 64-len); + memset((void *) (dp->addr + len), 0, 64-len); len = 64; }