On Saturday 08 October 2011 20:20:47 Pali Rohár wrote:
On Thursday 01 September 2011 09:57:13 you wrote:
On Thursday, September 01, 2011 07:34:29 Pali Rohár wrote:
--- /dev/null +++ b/board/nokia/rx51/rx51.c
+GraphicDevice gdev;
no camel case
GraphicDevice is defined in include/video_fb.h
ok, nothing you can do about that
--- /dev/null +++ b/board/nokia/rx51/rx51.h
+const omap3_sysinfo sysinfo = {
you should not be defining variable storage in header files
this code was derivated from board/ti/beagle/beagle.h and beagle.h still has this code
beagle.h is broken too. please don't copy their brokenness :).
+/*
- IEN - Input Enable
- IDIS - Input Disable
- PTD - Pull type Down
- PTU - Pull type Up
- DIS - Pull type selection is inactive
- EN - Pull type selection is active
- M0 - Mode 0
- The commented string gives the final mux configuration for that pin
- */
this looks like SoC info and not board specific. should this be in an SoC header somewhere instead ?
all boards in board/ti/ has this code
dumb behavior shouldn't be encouraged :). that indicates even more strongly that this should be in a SoC header somewhere. -mike