On 11/20/2018 08:25 AM, Sven Schwermer wrote:
Hi Marek,
This allows building the SPL without driver model for USB. Since CONFIG_SPL_DM_USB is enabled if and only if CONFIG_DM_USB was enabled before, this patch does not change the build behaviour.
Signed-off-by: Sven Schwermer sven@svenschwermer.de
I asked before, but shouldn't this be 5/5 ?
Here are the reasons why I don’t think so:
- This particular order doesn’t break any builds. I triggered Travis CI runs for every patch in order and they have all succeeded.
- Before this patch series, DM was enabled for both SPL and proper when setting CONFIG_DM_USB=y.
Are you sure about this ? I recall boards which built SPL without DM and U-Boot with DM USB.
If I had done the s/CONFIG_DM_USB/CONFIG_IS_ENABLED(DM_USB)/ step before this patch, the DM would have suddenly been disabled for _all_ boards in their SPL builds. That would have definitively changed the existing behaviour. By doing it this way (CONFIG_SPL_DM_USB depends on CONFIG_DM_USB and the default for the former is “y”), IMHO nothing changes.
I have difficulties seeing any advantages doing this patch last.
If you're sure this doesn't enable SPL_DM_USB on boards where it was previously disabled, fine by me.