
22 Jun
2017
22 Jun
'17
9:20 a.m.
Dear Tom,
In message 20170621152200.GJ27196@bill-the-cat you wrote:
With what I'm going to send out as a v2 of the rest of the series, I'm OK with not including an empty directory for now and bringing back mpc8xx, thanks again!
Sorry, but I disagree here.
This revert series is a mess. It does not simply re-add 8xx support, it reverts everything and then re-removes everything except 8xx. This is totally unnecessary and ugly. Please do not accept these patches.
Also, as Heiko already mentioned, if we re-add 8xx support, this should be done in a way that matches today's requirements. The code needs cleanup everywhere: directory layout, Kconfig, DM support, I/O accessors, etc.
NAK!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
A wise man asks himself the reason for his mistakes, while a fool
will ask others.