Re: [U-Boot] [PATCH v5 2/9] dfu: Support larger than memory transfers.

On Mon, Mar 11, 2013 at 11:03:41AM +0100, Lukasz Majewski wrote:

[snip]

...

...

• if (blk_seq_num == 0) {

• i_buf = dfu_buf;
  

• ret = dfu->read_medium(dfu, i_buf, &r_size);
  

• debug("%s: %s %ld [B]\n", __func__, dfu->name,
  

r_size);

• i_blk_seq_num = 0;
  

• /* Integrity check (if needed) */
  

• crc = crc32(0, dfu_buf, r_size);
  

•       __func__, dfu->name, buf, size, blk_seq_num,
  

dfu->i_buf); +

• if (!dfu->inited) {

• ret = dfu->read_medium(dfu, 0, NULL, &dfu->r_left);
  

	   ^^^^^^^^^^^^ this call causes read error. I
	   suppose, that it is an initial "read". Does
	   it read the whole file at once?

The problem is that the command is fromatted in a
wrong way. 

And we're also passing NULL as the buffer to read into? That also can't be good. I'll spend a little time here and see what's going on.