Re: [PATCH v2 1/1] bootm: Fix flags used for bootargs string substitution

29 Nov 2023


      On Fri, 24 Nov 2023 at 09:35, Piotr Kubik piotr.kubik@iopsys.eu wrote:
...
Commit 51bb33846ad2 ("bootm: Support string substitution in
bootargs") introduced a feature of bootargs string substitution
and changed a flag used in bootm_process_cmdline_env() call
to be either true or false. With this flag value,
condition in bootm_process_cmdline()
`if (flags & BOOTM_CL_SUBST)` is never true
and process_subst() is never called.
Add a simple test to verify if substitution works OK.
Signed-off-by: Piotr Kubik piotr.kubik@iopsys.eu
boot/bootm.c              | 6 +++++-
 test/py/tests/test_fit.py | 8 ++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
Thank you