Re: [U-Boot] [PATCH v3 1/2] initial support for pengwyn board

On Wed, Jan 29, 2014 at 04:39:02PM +0100, Lothar Felten wrote:

[snip]

+ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_NOR_BOOT),y) +obj-y := mux.o +endif

Here and elsewhere, correct these tests as you don't support CONFIG_NOR_BOOT on this platform.

• /* the pengwyn board uses the TPS650250 PMIC without I2C */
• /* interface and will output the following fixed voltages: */

/* * Like this * please. */

+#ifdef CONFIG_BOARD_LATE_INIT +int board_late_init(void) +{

• return 0;

+} +#endif

Please do a pre-patch that moves CONFIG_BOARD_LATE_INIT from <configs/ti_am335x_common.h> to the board ports, and then you can drop this hunk.

• "nandsrcaddr=0x280000\0" \

• "nandboot=echo Booting from nand ...; " \
  

• "run nandargs; " \
  

• "nand read ${loadaddr} ${nandsrcaddr} ${nandimgsize}; " \
  

• "bootz ${loadaddr}\0" \
  

(a) indentation is wrong (and a copy/pasted problem) and (b) you don't handle the device tree here.

• "spiboot=echo Booting from spi ...; " \

• "run spiargs; " \
  

• "sf probe ${spibusno}:0; " \
  

• "sf read ${loadaddr} ${spisrcaddr} ${spiimgsize}; " \
  

• "bootz ${loadaddr}\0" \
  

Same and unused?

• "findfdt="\

• "if test $board_name = A335BONE; then " \
  

• 	"setenv fdtfile am335x-bone.dtb; fi; " \
  

• "if test $board_name = A335BNLT; then " \
  

• 	"setenv fdtfile am335x-boneblack.dtb; fi; " \
  

• "if test $board_name = A33515BB; then " \
  

• 	"setenv fdtfile am335x-evm.dtb; fi; " \
  

• "if test $board_name = A335X_SK; then " \
  

• 	"setenv fdtfile am335x-evmsk.dtb; fi; " \
  

• "if test $fdtfile = undefined; then " \
  

• 	"echo WARNING: no device tree found; fi; \0" \
  

Nonsense for this board.

Thanks!