Re: [PATCH v6 15/21] binman: Add compression tests

On Fri, 19 Aug 2022 at 08:26, Stefan Herbrechtsmeier stefan.herbrechtsmeier-oss@weidmueller.com wrote:

From: Stefan Herbrechtsmeier stefan.herbrechtsmeier@weidmueller.com

Add common test functions to test all supported compressions.

Signed-off-by: Stefan Herbrechtsmeier stefan.herbrechtsmeier@weidmueller.com Reviewed-by: Simon Glass sjg@chromium.org

---

Instead of the for loop it is possible to use Parameterized [1] testing.

[1] https://github.com/wolever/parameterized

(no changes since v5)

Changes in v5:

• Use self.comp_bintools dict
• Use _CheckBintool(bintool) function

Changes in v3:

• Use 'tools.get_bytes(0, 64)' instead of 'bytes([0]) * 64'
• Check if tool is present
• Rename tests

Changes in v2:

• Add commit to add compression tests

tools/binman/ftest.py | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)

Reviewed-by: Simon Glass sjg@chromium.org

Applied to u-boot-dm, thanks!